smiklosovic commented on code in PR #3931:
URL: https://github.com/apache/cassandra/pull/3931#discussion_r1984617186
##########
src/java/org/apache/cassandra/auth/AuthConfig.java:
##########
@@ -82,7 +85,7 @@ public static void applyAuth()
IRoleManager roleManager = authInstantiate(conf.role_manager,
CassandraRoleManager.class);
if (authenticator instanceof PasswordAuthenticator && !(roleManager
instanceof CassandraRoleManager))
- throw new ConfigurationException("CassandraRoleManager must be
used with PasswordAuthenticator", false);
+ throw new
ConfigurationException(authenticator.getClass().getName() + " requires
CassandraRoleManager", false);
Review Comment:
@tiagomlalves you might probably do `CassandraRoleManager.class.getName()`
as well. Why do we `.getName()` authenticator but not role manager? You do that
above on lines 77/78.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
