smiklosovic commented on code in PR #3394:
URL: https://github.com/apache/cassandra/pull/3394#discussion_r1986820183
##########
src/java/org/apache/cassandra/service/StorageService.java:
##########
@@ -4184,14 +4184,14 @@ private LinkedHashMap<InetAddressAndPort, Float>
getEffectiveOwnership(String ke
if (keyspace != null)
{
if (isLocalSystemKeyspace(keyspace))
- throw new IllegalStateException("Ownership values for
keyspaces with LocalStrategy are meaningless");
+ throw new IllegalStateException("Ownership values for
keyspaces " + keyspace + " with LocalStrategy are meaningless");
Review Comment:
@maoling I do not think this is necessary. This code path is exercised when
`keyspace != null` so a user knows which keyspace it is talking about, no?
(Except of that, the constructed message is grammatically incorrect).
##########
src/java/org/apache/cassandra/service/StorageService.java:
##########
@@ -4184,14 +4184,14 @@ private LinkedHashMap<InetAddressAndPort, Float>
getEffectiveOwnership(String ke
if (keyspace != null)
{
if (isLocalSystemKeyspace(keyspace))
- throw new IllegalStateException("Ownership values for
keyspaces with LocalStrategy are meaningless");
+ throw new IllegalStateException("Ownership values for
keyspaces " + keyspace + " with LocalStrategy are meaningless");
KeyspaceMetadata keyspaceInstance =
metadata.schema.getKeyspaces().getNullable(keyspace);
if (keyspaceInstance == null)
throw new IllegalArgumentException("The keyspace " + keyspace
+ ", does not exist");
if (keyspaceInstance.replicationStrategy instanceof LocalStrategy)
- throw new IllegalStateException("Ownership values for
keyspaces with LocalStrategy are meaningless");
+ throw new IllegalStateException("Ownership values for
keyspaces " + keyspace + " with LocalStrategy are meaningless");
Review Comment:
@maoling same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
