smiklosovic commented on code in PR #3394:
URL: https://github.com/apache/cassandra/pull/3394#discussion_r1986836015
##########
src/java/org/apache/cassandra/service/StorageService.java:
##########
@@ -4209,7 +4209,10 @@ private LinkedHashMap<InetAddressAndPort, Float>
getEffectiveOwnership(String ke
for (String keyspaceName : userKeyspaces)
{
if
(!Schema.instance.getKeyspaceInstance(keyspaceName).getReplicationStrategy().hasSameSettings(replicationStrategy))
- throw new IllegalStateException("Non-system keyspaces
don't have the same replication settings, effective ownership information is
meaningless");
+ throw new IllegalStateException(String.format(
+ "Non-system keyspaces: %s and %s don't have the same
replication settings, effective ownership information is meaningless",
Review Comment:
@maoling you might probably gather all keyspaces for which replication
settings are different and enrich exception message with them?
However, there might be in theory dozens of keyspaces and it might pollute
the output unnecessarily. Not sure how to control that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
