smiklosovic commented on code in PR #3381:
URL: https://github.com/apache/cassandra/pull/3381#discussion_r1986857105
##########
build.xml:
##########
@@ -490,15 +490,26 @@
</target>
<!-- create properties file with C version -->
- <target name="_createVersionPropFile"
depends="_get-git-sha,set-cqlsh-version">
+ <target name="_createVersionPropFile"
depends="_get-git-sha,set-cqlsh-version,_set-build-date">
<taskdef name="propertyfile"
classname="org.apache.tools.ant.taskdefs.optional.PropertyFile"/>
<mkdir dir="${version.properties.dir}"/>
<propertyfile file="${version.properties.dir}/version.properties">
<entry key="CassandraVersion" value="${version}"/>
<entry key="GitSHA" value="${git.sha}"/>
+ <entry key="BuildDate" value="${build.date}"/>
</propertyfile>
</target>
+ <!-- set ant build date -->
+ <target name="_set-build-date">
+ <tstamp>
+ <format property="build.date" pattern="yyyy-MM-dd HH:mm:ss z"/>
+ </tstamp>
+ <!-- Include timezone information -->
+ <property environment="env"/>
Review Comment:
@maoling I dont think this is necessary. I think that preparing build date
pattern with UTC timezone is just enough.
##########
src/java/org/apache/cassandra/config/CassandraRelevantProperties.java:
##########
@@ -50,6 +50,7 @@ public enum CassandraRelevantProperties
ALLOW_UNSAFE_JOIN("cassandra.allow_unsafe_join"),
ALLOW_UNSAFE_REPLACE("cassandra.allow_unsafe_replace"),
ALLOW_UNSAFE_TRANSIENT_CHANGES("cassandra.allow_unsafe_transient_changes"),
+ ANT_BUILD_DATE("cassandra.buildDate"),
Review Comment:
I would prefer `cassandra.build_date`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
