smiklosovic commented on code in PR #3381:
URL: https://github.com/apache/cassandra/pull/3381#discussion_r1986858120
##########
src/java/org/apache/cassandra/config/CassandraRelevantProperties.java:
##########
@@ -50,6 +50,7 @@ public enum CassandraRelevantProperties
ALLOW_UNSAFE_JOIN("cassandra.allow_unsafe_join"),
ALLOW_UNSAFE_REPLACE("cassandra.allow_unsafe_replace"),
ALLOW_UNSAFE_TRANSIENT_CHANGES("cassandra.allow_unsafe_transient_changes"),
+ ANT_BUILD_DATE("cassandra.buildDate"),
Review Comment:
I would prefer `BUILD_DATE`. Cassandra's code base should not be informing
what build tool it was built with.
##########
src/java/org/apache/cassandra/config/CassandraRelevantProperties.java:
##########
@@ -50,6 +50,7 @@ public enum CassandraRelevantProperties
ALLOW_UNSAFE_JOIN("cassandra.allow_unsafe_join"),
ALLOW_UNSAFE_REPLACE("cassandra.allow_unsafe_replace"),
ALLOW_UNSAFE_TRANSIENT_CHANGES("cassandra.allow_unsafe_transient_changes"),
+ ANT_BUILD_DATE("cassandra.buildDate"),
Review Comment:
I would prefer `BUILD_DATE`. Cassandra's code base should not be informing
what build tool it was built with. It is irrelevant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
