5 commented on code in PR #198:
URL: https://github.com/apache/cassandra-sidecar/pull/198#discussion_r1987945295
##########
client-common/src/main/java/org/apache/cassandra/sidecar/common/ApiEndpointsV1.java:
##########
@@ -121,13 +121,16 @@ public final class ApiEndpointsV1
public static final String LIST_CDC_SEGMENTS_ROUTE = API_V1 + CDC_PATH +
"/segments";
public static final String STREAM_CDC_SEGMENTS_ROUTE =
LIST_CDC_SEGMENTS_ROUTE + "/" + SEGMENT_PATH_PARAM;
+ // Schema Reporting
+ private static final String REPORT_SCHEMA = "/report-schema";
+ public static final String REPORT_SCHEMA_ROUTE = API_V1 + REPORT_SCHEMA;
Review Comment:
I would agree that `PUT .../schema` (singular, not plural) is an appropriate
name if we provide the schema we intent to persist. But we're not putting
schema in. We're triggering an event that causes the schema to be internally
produced and reported. Using `PUT .../schema-report` would probably follow the
general idea of REST better. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
