yifan-c commented on code in PR #198:
URL: https://github.com/apache/cassandra-sidecar/pull/198#discussion_r1987740739
##########
client-common/src/main/java/org/apache/cassandra/sidecar/common/ApiEndpointsV1.java:
##########
@@ -121,13 +121,16 @@ public final class ApiEndpointsV1
public static final String LIST_CDC_SEGMENTS_ROUTE = API_V1 + CDC_PATH +
"/segments";
public static final String STREAM_CDC_SEGMENTS_ROUTE =
LIST_CDC_SEGMENTS_ROUTE + "/" + SEGMENT_PATH_PARAM;
+ // Schema Reporting
+ private static final String REPORT_SCHEMA = "/report-schema";
+ public static final String REPORT_SCHEMA_ROUTE = API_V1 + REPORT_SCHEMA;
Review Comment:
I agree. The API should not contain verb. Given the API is to interact with
DataHub, I would suggest the following to explicitly refer to DataHub
```
PUT /api/v1/datahub/schemas
```
Meaning, update the schema in datahub.
The API on the datahub side is `/openapi/entities/v1`. Maybe `entities` also
work if we want to define a similar API. However, I think `schemas` provides
better clarity in the context of Sidecar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
