joao-r-reis commented on code in PR #1855:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1855#discussion_r2001305036
##########
marshal.go:
##########
@@ -1579,7 +2113,8 @@ func writeCollectionSize(info CollectionType, n int, buf
*bytes.Buffer) error {
return nil
}
-func marshalList(info TypeInfo, value interface{}) ([]byte, error) {
+// Marshal marshals the value for the given TypeInfo into a byte slice.
+func (listSetCQLType) Marshal(info TypeInfo, value interface{}) ([]byte,
error) {
listInfo, ok := info.(CollectionType)
Review Comment:
The fact that this implementation relies on accessing `listInfo.proto` which
isn't exported shows that there needs to be a better (and accessible) way of
knowing what protocol version is being used otherwise user defined
registrations won't be able to do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
