jameshartig commented on code in PR #1855:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1855#discussion_r2021090498
##########
marshal.go:
##########
@@ -2456,37 +3292,29 @@ func unmarshalUDT(info TypeInfo, data []byte, value
interface{}) error {
return nil
}
-// TypeInfo describes a Cassandra specific data type.
+// TypeInfo describes a Cassandra specific data type. Typically this is just a
+// Type but can be a struct when more information is needed.
+// TODO: move to types.go
type TypeInfo interface {
Type() Type
- Version() byte
- Custom() string
-
- // NewWithError creates a pointer to an empty version of whatever type
- // is referenced by the TypeInfo receiver.
- //
- // If there is no corresponding Go type for the CQL type, NewWithError
returns an error.
- NewWithError() (interface{}, error)
}
+// NativeType is a simple type that is defined by the Cassandra protocol.
+// Deprecated. Use Type instead.
+// TODO: move to types.go
type NativeType struct {
proto byte
Review Comment:
This is really only needed for the protocol 2 UDT error. `NativeType` and
`NewNativeType` are also a publicly exposed and there might be usages that
expect there to be a protocol option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
