worryg0d commented on PR #1755:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1755#issuecomment-2742758285
Hello, @joao-r-reis!
I like the proposal. Debugging gocql is a real headache sometimes. Getting
rid of the `gocql_debug` build tag is also a good idea to simplify the
debugging process for end users.
The new API looks good to me. It lacks Trace() but I don't think we need
this.
Having something like groups to log different driver components (conn, pool,
queryExecutor) is probably a good idea, but it will make implementing the
interface a bit harder, and some logging libraries may not provide this
feature...
```
func Group(fields ...string) StructuredLogger
```
Anyway, it can be handled on the driver side by just adding corresponding
fields.
> considered log/slog instead of creating a new Structured Logger interface
from scratch but log/slog was only introduced in go 1.21 so I discarded this
option for now.
Yeah, this is a shame. It would be cool if it depended on the existing
logging interfaces as slog. We should actually decide the go version gocql will
be bumped to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
