jameshartig commented on code in PR #1755:
URL: 
https://github.com/apache/cassandra-gocql-driver/pull/1755#discussion_r2141361888


##########
conn_test.go:
##########
@@ -349,15 +350,21 @@ func TestCancel(t *testing.T) {
 type testQueryObserver struct {
        metrics map[string]*hostMetrics
        verbose bool
-       logger  StdLogger
+       logger  StructuredLogger
 }
 
 func (o *testQueryObserver) ObserveQuery(ctx context.Context, q ObservedQuery) 
{
        host := q.Host.ConnectAddress().String()
        o.metrics[host] = q.Metrics
        if o.verbose {

Review Comment:
   Since we have log levels now, I think we might be able to do away with this 
verbose mode. But that could be in a follow-up PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to