jahstreet commented on code in PR #2013:
URL:
https://github.com/apache/cassandra-java-driver/pull/2013#discussion_r2009087227
##########
core/pom.xml:
##########
@@ -116,6 +116,11 @@
<groupId>org.reactivestreams</groupId>
<artifactId>reactive-streams</artifactId>
</dependency>
+ <dependency>
+ <groupId>com.github.seancfoley</groupId>
+ <artifactId>ipaddress</artifactId>
+ <optional>true</optional>
+ </dependency>
Review Comment:
We need at least the following functionality to work with subnets here:
- Validate subnet string is in a prefix block format
- Check if subnet contains IP address
- All for IPv4 and IPv6
The library is quite big, so copying over its parts is an overkill.
Then the alternative is to implement these functions ourselves.
Looking into it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
