joao-r-reis commented on PR #1868: URL: https://github.com/apache/cassandra-gocql-driver/pull/1868#issuecomment-2751421634
> What about making the methods `Exec(context.Context)` and `Iter(context.Context) error` so there's no need to shallow copy query in `WithContext`? This is a bigger change though that we might not want to make. Taht said, I think Query would be a bit easier to re-use then. I know this differs from `http.Request` but in that case it might be a symptom of not wanting to break the existing API when context's were introduced. I like the idea but I think it would be too much to ask of users when upgrading since it would affect every single statement on their app... I'd be down to adding an overload and deprecating `WithContext` though... I just don't know what names would fit for the new Iter/Exec overloads... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
