joao-r-reis commented on PR #1868: URL: https://github.com/apache/cassandra-gocql-driver/pull/1868#issuecomment-2751405836
> > With this PR, this method is deprecated on Query and Batch since these two types no longer implement ExecutableQuery so we can keep the Query/Batch API much simpler. > > Why not just remove it? Seems like any `HostSelectionPolicy` implementation would need to make major changes already. Hmm I don't think `HostSelectionPolicy` implementations have to make major changes after this PR unless they rely on casting the `ExecutableQuery` object into `Query` or `Batch` (and even this is a small change, they just need to call .Statement() before doing so). > I don't want to bikeshed about names but ExecutableQuery is a bit confusing since it contains Query and Batch. Did that name come from somewhere? Would ExecutableStatement make more sense since it has a statement? I kept `ExecutableQuery` name unchanged so `HostSelectionPolicy` implementations can pretty much continue to work without many changes (or even any change at all). cc @lukasz-antoniak because you also brought this up in 1 of your comments. I'm concerned that renaming this interface will increase the chance users will have to change their code when upgrading the driver but I do agree that the current name isn't good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
