ekaterinadimitrova2 commented on code in PR #3955:
URL: https://github.com/apache/cassandra/pull/3955#discussion_r2027733369
##########
src/java/org/apache/cassandra/index/SecondaryIndexManager.java:
##########
@@ -847,8 +847,6 @@ private synchronized void markIndexFailed(Index index,
boolean isInitialBuild)
if
(!index.getSupportedLoadTypeOnFailure(isInitialBuild).supportsReads() &&
queryableIndexes.remove(indexName))
logger.info("Index [{}] became not-queryable because of failed
build.", indexName);
-
- makeIndexNonQueryable(index, Index.Status.BUILD_FAILED);
Review Comment:
This doesn't work as recently we overrode the `isQueryable` for
`CassandraIndex`, and `BUILD_FAILED` is a non-queryable index, but
`FULL_REBUILD_STARTED` is queryable. So, we would introduce a change of
behavior with this call, which we do not want to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
