netudima commented on code in PR #4035:
URL: https://github.com/apache/cassandra/pull/4035#discussion_r2026788930
##########
test/unit/org/apache/cassandra/io/util/ThreadLocalReadAheadBufferTest.java:
##########
@@ -139,10 +139,9 @@ private Gen<InputData> lastBlockReads()
private Gen<InputData> randomReads()
Review Comment:
the generator after the change looks identical to lastBlockReads()..
it also looks like the naming is mixed up: randomReads was about reading
the last block (before the current change) and lastBlockReads is about reading
from anywhere.
should we preserve reading the test to read the last block by using max(0,
fileSize(file) - blockSize)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
