netudima commented on code in PR #4035:
URL: https://github.com/apache/cassandra/pull/4035#discussion_r2026799971
##########
test/unit/org/apache/cassandra/io/util/ThreadLocalReadAheadBufferTest.java:
##########
@@ -139,10 +139,9 @@ private Gen<InputData> lastBlockReads()
private Gen<InputData> randomReads()
{
- int blockSize = new
DataStorageSpec.IntKibibytesBound("256KiB").toBytes();
return arbitrary().pick(List.of(files))
.flatMap((file) ->
- lists().of(longs().between(fileSize(file) -
blockSize, fileSize(file)).zip(integers().between(1, 100), Pair::create))
+ lists().of(longs().between(0,
fileSize(file)).zip(integers().between(1, 100), Pair::create))
Review Comment:
if I got the logic correctly we only test a single block read by using small
sizes in 1..100 range ? I is a valid scenario to read more than 1 block? (when
somebody set the buffer size to a value smaller than a chunk size)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
