joao-r-reis commented on PR #1822: URL: https://github.com/apache/cassandra-gocql-driver/pull/1822#issuecomment-2733326071
> Thanks a lot! > > I also noticed that [CI](https://github.com/apache/cassandra-gocql-driver/blob/65e2cafa8c46534a1aef83d5483302d23f7cb792/.github/workflows/main.yml#L40) doesn't run tests without any compression. Should I add it to the matrix? With proto v5 it makes sense to add them because we have different segment format for compressed and uncompressed segments This makes sense, sorry to take a long time to get back to this, do you mind adding this before we merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
