absurdfarce commented on code in PR #2033:
URL:
https://github.com/apache/cassandra-java-driver/pull/2033#discussion_r2036061872
##########
pom.xml:
##########
@@ -575,7 +575,7 @@
</analysisConfiguration>
<oldArtifacts>
<!-- The previous release used DataStax groupId, remove this
after the next release -->
-
<artifact>com.datastax.oss:${project.artifactId}:RELEASE</artifact>
+
<artifact>org.apache.cassandra:${project.artifactId}:RELEASE</artifact>
Review Comment:
Oooooh, `${project.groupId}`... that's an _excellent_ point @aratno! I'm 💯
doing that.
I freely acknowledge that my knowledge of Maven is pretty basic (and that
even that is charitable) so please set me straight if anything I say from this
point forward is, well, dumb. It _seems like_ the primary interest in using
this plugin is to detect cases where we change some part of the contract it
enforces within a PR. Most of the time when I've seen this run it's comparing
something like "4.19.1-SNAPSHOT" to "4.19.0" which seems exactly right for a
PR. Assuming I understand that right (and I'm not at all sure I do... plus I'm
pretty tired right now) it seems like we'd _want_ this to run as part of verify
wouldn't we?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
