belliottsmith commented on code in PR #4074:
URL: https://github.com/apache/cassandra/pull/4074#discussion_r2036718810
##########
test/simulator/main/org/apache/cassandra/simulator/systems/InterceptingExecutorFactory.java:
##########
@@ -327,8 +326,11 @@ public ExecutorPlus pooled(String name, int threads)
return configurePooled(name, threads).build();
}
- public Thread startThread(String name, Runnable runnable, Daemon daemon)
+ public Thread startThread(String name, Runnable runnable,
InfiniteLoopExecutor.SimulatorTag simulatorTag)
{
+ if (simulatorTag == InfiniteLoopExecutor.SimulatorTag.INFINITE_LOOP)
Review Comment:
`switch`? Should probably handle all three cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
