belliottsmith commented on code in PR #4074:
URL: https://github.com/apache/cassandra/pull/4074#discussion_r2036705873
##########
src/java/org/apache/cassandra/concurrent/InfiniteLoopExecutor.java:
##########
@@ -53,12 +53,17 @@ public enum InternalState { SHUTTING_DOWN_NOW, TERMINATED }
public enum SimulatorSafe { SAFE, UNSAFE }
/**
- * Does this loop always block on some external work provision that is
going to be simulator-controlled, or does
- * it loop periodically? If the latter, it may prevent simulation making
progress between phases, and should be
- * marked as a DAEMON process.
+ * Simulator Tag specifies the nature of the created thread:
+ *
+ * * JOB threads are short-lived, and simulation will wait for them to
terminate before completing an enclosing Work unit
+ * * DAEMON threads can outlive the enclosing work unit during
simulation; and will also
+ * * INFINITE_LOOP threads are intended for looping "forever", and are
explicitly marked as such to distinguish them from
Review Comment:
INFINITE_LOOP threads detach from their parent task as they are expected to
run forever, but unlike DAEMON threads must have no active work for a given
Work phase to complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
