belliottsmith commented on code in PR #4068:
URL: https://github.com/apache/cassandra/pull/4068#discussion_r2036938479
##########
src/java/org/apache/cassandra/db/marshal/ValueAccessor.java:
##########
@@ -525,23 +525,23 @@ public static <V> int
putLeastSignificantBytes(ValueAccessor<V> accessor, V dst,
break;
case 3:
accessor.putShort(dst, offset, (short)(register >>> 8));
- accessor.putByte(dst, offset, (byte)register);
+ accessor.putByte(dst, offset + 2, (byte)register);
Review Comment:
I think this version of the method just wasn't used before, as it was
totally broken. I think the tests included with this patch should cover its
functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
