belliottsmith commented on code in PR #4068: URL: https://github.com/apache/cassandra/pull/4068#discussion_r2036954430
########## src/java/org/apache/cassandra/service/accord/serializers/IVersionedWithKeysSerializer.java: ########## @@ -323,44 +277,132 @@ private void serializeLargeSubset(AbstractRanges serialize, int serializeCount, } } + public Routables<?> deserializeSubsetInternal(Routables<?> superset, DataInputPlus in) throws IOException Review Comment: this particular caller now uses some of the internal methods this method calls directly. But, I have another patch in flight that may invoke these methods directly, and anyway they may be useful for the future so would prefer not to delete them here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org