dcapwell commented on code in PR #4078: URL: https://github.com/apache/cassandra/pull/4078#discussion_r2040319701
########## src/java/org/apache/cassandra/db/marshal/ByteBufferAccessor.java: ########## @@ -318,13 +318,13 @@ public int putFloat(ByteBuffer dst, int offset, float value) @Override public int putLeastSignificantBytes(ByteBuffer dst, int offset, long register, int bytes) { - if (dst.remaining() < Long.BYTES) + int pos = dst.position() + offset; Review Comment: what motivated this change? I just found these methods so ported the fuzz tests i made for the data input/output version and looks fine so far without these changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org