belliottsmith commented on code in PR #4078: URL: https://github.com/apache/cassandra/pull/4078#discussion_r2040342605
########## src/java/org/apache/cassandra/db/partitions/PartitionUpdate.java: ########## @@ -810,6 +814,19 @@ public void serialize(PartitionUpdate update, DataOutputPlus out, int version) t } } + public void serializeWithoutKey(PartitionUpdate update, TableMetadatas tables, DataOutputPlus out, int version) throws IOException + { + try (UnfilteredRowIterator iter = update.unfilteredIterator()) + { + assert !iter.isReverseOrder(); Review Comment: I am fairly sure this is copy/paste. I can take another look, you’re probably right that we can remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org