dcapwell commented on code in PR #4089:
URL: https://github.com/apache/cassandra/pull/4089#discussion_r2042528169
##########
src/java/org/apache/cassandra/service/accord/AccordService.java:
##########
@@ -399,9 +399,10 @@ else if (images.isEmpty()) // First boot, single-node
cluster
int waitSeconds = 5;
while (true)
{
+ Epoch await = Epoch.create(configService.currentEpoch());
Review Comment:
any idea why this was done? we have this block above
```
metadata = ClusterMetadata.current();
highestKnown = configService.currentEpoch();
if (metadata.epoch.getEpoch() > highestKnown)
{
remote = fetchTopologies(highestKnown + 1);
if (remote != null)
remote.forEach(configService::reportTopology,
highestKnown + 1, Integer.MAX_VALUE);
}
```
so, `if (metadata.epoch.getEpoch() > highestKnown)` "should" try to fetch
topologies and load them, so the only time i see `metadata.epoch` not being
fine is if that loaded nothing? which could imply we spoke to the "wrong" nodes
about this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
