dcapwell commented on code in PR #4089:
URL: https://github.com/apache/cassandra/pull/4089#discussion_r2042547824
##########
src/java/org/apache/cassandra/service/accord/AccordService.java:
##########
@@ -399,9 +399,10 @@ else if (images.isEmpty()) // First boot, single-node
cluster
int waitSeconds = 5;
while (true)
{
+ Epoch await = Epoch.create(configService.currentEpoch());
Review Comment:
I am +1 to `max(metadata.epoch(), configService.currentEpoch())` but worried
about only using `configService.currentEpoch()`.
The code above should give a property that `configService.currentEpoch() >=
metadata.epoch()`, and this propery should only break under 2 conditions
1) TCM knows 0 peers... in which case we are a single node cluster, so
shouldn't TCM be notifying us of this epoch?
2) every single `peer` in the cluster sent a failure response back (or after
several retries we gave up)... this seems problematic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
