dcapwell commented on code in PR #4105:
URL: https://github.com/apache/cassandra/pull/4105#discussion_r2051170031
##########
src/java/org/apache/cassandra/index/sai/disk/v1/MemtableIndexWriter.java:
##########
@@ -218,7 +218,7 @@ private void flushVectorIndex(long startTime, Stopwatch
stopwatch) throws IOExce
private void completeIndexFlush(long cellCount, long startTime, Stopwatch
stopwatch) throws IOException
{
// create a completion marker indicating that the index is complete
and not-empty
- ColumnCompletionMarkerUtil.create(indexDescriptor, indexIdentifier,
false);
+ ColumnCompletionMarkerUtil.create(indexDescriptor, indexIdentifier,
cellCount == 0);
Review Comment:
this is the actual patch for the bug fix. Repair is causing multiple
sstables to be generated, and the tests do partial partition/row updates, so
SAI sees a column as having data, but it didn't write anything for *this
range*... this leads to `cellCount == 0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
