dcapwell commented on code in PR #4105:
URL: https://github.com/apache/cassandra/pull/4105#discussion_r2051172285
##########
test/distributed/org/apache/cassandra/distributed/test/cql3/SingleNodeTableWalkTest.java:
##########
@@ -371,6 +371,8 @@ public void test() throws IOException
.add(this::selectTokenRange))
.addIf(State::hasEnoughMemtable,
StatefulASTBase::flushTable)
.addIf(State::hasEnoughSSTables,
StatefulASTBase::compactTable)
+ .addAllIf(BaseState::allowRepair, b ->
b.add(StatefulASTBase::incrementalRepair)
+
.addIf(BaseState::isConsistent, StatefulASTBase::previewRepair))
Review Comment:
preview repairs fails if it finds a mismatch, so we can only call it safely
in the test when we *know* we should be consistent.
for accord, we flush during the `prepare` phase, which is *before* we do any
barriers, so we can't just say "accord makes us consistent", because we might
not be (you need to go through accord to be consistent).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
