joao-r-reis commented on PR #1875: URL: https://github.com/apache/cassandra-gocql-driver/pull/1875#issuecomment-2818077493
Hmm I don't like the idea of introducing a dependency on the number of connection pools but wrapping `hostIter` won't solve the issue because whether the host is down or nil doesn't matter much, it will lead to the same behavior... I actually think it's fine for the driver to assume that the host selection policy is behaving correctly (i.e. not returning the same host over and over) but we still have the issue that in #1793 we added an internal policy that does this (returns the same host everytime the function is called). I've commented this before but I truly think the best option would be to make the internal host selection policy added in #1793 return the host only once even if that comes at a cost of having no retries or speculative executions when the user uses this feature. Later down the line if we see that there is demand for retries/speculative executions when the featured added in #1793 is used then we can reevaluate. One potential alternative if we absolutely want to keep retries when a specific host is being targeted by the query is to add a special flag so that the query executor treats this host selection policy differently (i.e. break from the loop immediately when the returned host is nil or downed). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
