tengu-alt commented on code in PR #1875:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1875#discussion_r2081357854
##########
query_executor.go:
##########
@@ -89,14 +89,18 @@ func (q *queryExecutor) executeQuery(qry ExecutableQuery)
(*Iter, error) {
// check if the host id is specified for the query,
// if it is, the query should be executed at the corresponding host.
if hostID := qry.GetHostID(); hostID != "" {
+ pool, ok := q.pool.getPoolByHostID(hostID)
+ if !ok || !pool.host.IsUp() {
+ return nil, ErrNoConnections
+ }
+ host := pool.host
hostIter = func() SelectedHost {
- pool, ok := q.pool.getPoolByHostID(hostID)
- // if the specified host is down
- // we return nil to avoid endless query execution in
queryExecutor.do()
- if !ok || !pool.host.IsUp() {
- return nil
+ if host != nil {
Review Comment:
Understood, refactored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
