smiklosovic commented on code in PR #4115:
URL: https://github.com/apache/cassandra/pull/4115#discussion_r2060038192
##########
src/antlr/Parser.g:
##########
@@ -967,8 +967,8 @@ tableDefinition[CreateTableStatement.Raw stmt]
;
tableColumns[CreateTableStatement.Raw stmt]
- @init { boolean isStatic = false; }
- : k=ident v=comparatorType (K_STATIC { isStatic = true; })?
(mask=columnMask)? (constraints=columnConstraints)? { $stmt.addColumn(k, v,
isStatic, mask, constraints); }
+ @init { boolean isStatic = false; boolean isNotNull = false; }
+ : k=ident v=comparatorType (K_STATIC { isStatic = true; })? (K_NOT K_NULL
{ isNotNull = true; })? (mask=columnMask)? (constraints=columnConstraints)? {
$stmt.addColumn(k, v, isStatic, isNotNull, mask, constraints); }
Review Comment:
will enable `create table ks.tb (id int, val int not null)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
