smiklosovic commented on code in PR #4115: URL: https://github.com/apache/cassandra/pull/4115#discussion_r2073459884
########## pylib/cqlshlib/test/test_cqlsh_completion.py: ########## @@ -1154,7 +1154,7 @@ def test_complete_in_alter_table(self): other_choices_ok=True) self.trycompletions('ALTER TABLE new_table ADD col int C', immediate='HECK ') self.trycompletions('ALTER TABLE new_table ADD col int CHECK ', - choices=['<identifier>', '<quotedName>', 'JSON', 'LENGTH', 'NOT_NULL', 'OCTET_LENGTH', 'REGEXP'], Review Comment: we can not do "NOT NULL" here ... it just does not play together with space in it. When "NOT" is suggested and a user types it and pushes "<tab>", "NULL" will be added automatically. At least something ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org