michaelsembwever commented on code in PR #3899:
URL: https://github.com/apache/cassandra/pull/3899#discussion_r2077232664
##########
build.xml:
##########
@@ -664,6 +666,88 @@
</testmacro>
</target>
+ <!--
+ sstableloader build file
+ -->
+ <property name="sstableloader.build.src"
value="${basedir}/tools/sstableloader/src" />
+ <property name="sstableloader.test.src"
value="${basedir}/tools/sstableloader/test/unit" />
+ <property name="sstableloader.build.classes"
value="${build.classes}/sstableloader" />
+ <property name="sstableloader.test.classes"
value="${build.dir}/test/sstableloader-classes" />
+ <property name="sstableloader.manifest"
value="${sstableloader.build.classes}/MANIFEST.MF" />
+
+ <target name="sstableloader-build-test" depends="sstableloader-build"
description="Compile sstableloader tests">
+ <javac debug="true" debuglevel="${debuglevel}"
destdir="${sstableloader.test.classes}"
+ source="${ant.java.version}" target="${ant.java.version}"
+ includeantruntime="false" encoding="utf-8">
+ <classpath>
+ <path refid="cassandra.classpath.test"/>
+ <pathelement location="${sstableloader.build.classes}" />
+ </classpath>
+ <src path="${sstableloader.test.src}"/>
+ </javac>
+ </target>
+
+ <target name="sstableloader-build" depends="build" description="build
sstableloader">
+ <antcall target="_sstableloader_build"/>
+ </target>
+
+ <target name="_sstableloader_build">
+ <mkdir dir="${sstableloader.build.classes}" />
+ <javac compiler="modern" debug="true" debuglevel="${debuglevel}"
+ source="${ant.java.version}" target="${ant.java.version}"
+ encoding="utf-8" destdir="${sstableloader.build.classes}"
includeantruntime="true">
+ <src path="${sstableloader.build.src}" />
+ <classpath>
+ <path refid="cassandra.classpath" />
+ </classpath>
+ </javac>
+ </target>
+
+ <target name="sstableloader-test" depends="sstableloader-build-test,
maybe-build-test" description="Runs sstableloader tests">
+ <testmacro inputdir="${sstableloader.test.src}"
+ timeout="${test.timeout}">
+ </testmacro>
+ </target>
+
+ <target name="sstableloader-jar"
+ depends="sstableloader-build"
+ description="Assemble Cassandra sstableloader JAR files">
+
+ <!-- sstableloader jar -->
+ <manifest file="${sstableloader.manifest}">
+ <attribute name="Built-By" value="Apache Cassandra Project"/>
+ <attribute name="Main-Class"
value="org.apache.cassandra.tools.BulkLoader"/>
+ </manifest>
+ <mkdir dir="${sstableloader.build.classes}/META-INF" />
+ <mkdir dir="${build.dir}/tools/lib/" />
+ <jar destfile="${build.dir}/tools/lib/sstableloader.jar"
manifest="${sstableloader.manifest}">
+ <fileset dir="${sstableloader.build.classes}"/>
+ </jar>
+ </target>
+
+ <target name="sstableloader-javadoc" depends="build" description="Create
javadoc" unless="no-javadoc">
+ <create-javadoc destdir="${sstableloader-javadoc.dir}">
+ <filesets>
+ <fileset dir="${sstableloader.build.src}" defaultexcludes="yes">
+ <include name="org/apache/**/*.java"/>
+ </fileset>
+ </filesets>
+ </create-javadoc>
+ </target>
+
+ <target name="sstableloader-javadoc-jar" depends="sstableloader-javadoc"
unless="no-javadoc" description="Assemble sstableloader JavaDoc JAR file">
+ <jar jarfile="${build.dir}/${final.name}-sstableloader-javadoc.jar"
basedir="${sstableloader-javadoc.dir}"/>
+ <delete quiet="true" dir="${sstableloader-javadoc.dir}"/>
+ </target>
+
+ <target name="sstableloader-sources-jar" depends="init"
description="Assemble sstableloader Sources JAR file">
+ <jar jarfile="${build.dir}/${final.name}-sstableloader-sources.jar">
+ <fileset dir="${sstableloader.build.src}" defaultexcludes="yes">
+ <include name="org/apache/**/*.java"/>
+ </fileset>
+ </jar>
+ </target>
+
Review Comment:
looks good.
##########
.build/sstableloader-deps-template.xml:
##########
Review Comment:
looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
