tolbertam commented on code in PR #3899:
URL: https://github.com/apache/cassandra/pull/3899#discussion_r2041158276
##########
build.xml:
##########
@@ -2098,6 +2106,16 @@
file="${build.dir}/${final.name}-javadoc.jar"
classifier="javadoc"/>
+ <!-- the cassandra-sstableloader jar -->
+ <deploy pomFile="${build.dir}/${final.name}-sstableloader.pom"
+ file="${build.dir}/tools/lib/sstableloader.jar"/>
+ <deploy pomFile="${build.dir}/${final.name}-sstableloader.pom"
+ file="${build.dir}/${final.name}-sstableloader-sources.jar"
+ classifier="sources"/>
+ <deploy pomFile="${build.dir}/${final.name}-sstableloader.pom"
+ file="${build.dir}/${final.name}-sstableloader-javadoc.jar"
+ classifier="javadoc"/>
+
Review Comment:
This is a bit of compromise as I figure `publish` is called explicitly on
release, and I figure it likely that one would want to publish all artifacts
always. Alternatively we could use `antcall` and make a
`publish-sstableloader` task, but it would redundantly run tasks again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
