ekaterinadimitrova2 commented on code in PR #3696:
URL: https://github.com/apache/cassandra/pull/3696#discussion_r2084893480
##########
build.xml:
##########
@@ -307,6 +307,72 @@
<equals arg1="${ant.java.version}" arg2="17"/>
</condition>
+ <resources id="_jvm21_arg_items">
+ <string>-Djdk.attach.allowAttachSelf=true</string>
+
+ <string>-XX:+UseZGC</string>
Review Comment:
> but I'd definitely prefer to exercise all our test infrastructure on the
same GC we're recommending our users use and configuring by default on the JDK.
Totally agree on this. I guess my unstated assumption was that if we revert
in test, we will revert also in the default config for users. I had to say it
explicitly.
> So for now, let's hold off on reverting to G1, and I'll continue to push
through python dtest support on internal CI to support this branch and work
through test failures.
I don't mind, but in the meantime, I do not want to block this PR/work, too.
I am very happy with incremental changes, too. I will leave the final decision
to the author whether we want to revert to G1 (both in test and prod config
files) and commit this PR, or we want to work out the ZGC problem here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
