ekaterinadimitrova2 commented on code in PR #3696:
URL: https://github.com/apache/cassandra/pull/3696#discussion_r2085254702


##########
build.xml:
##########
@@ -307,6 +307,72 @@
         <equals arg1="${ant.java.version}" arg2="17"/>
     </condition>
 
+    <resources id="_jvm21_arg_items">
+        <string>-Djdk.attach.allowAttachSelf=true</string>
+
+        <string>-XX:+UseZGC</string>

Review Comment:
   > this is something David and others are seeing on a fork that includes this 
upstream work, not the ASF branch itself.
   That is a good clarification that was not mentioned earlier. Ignore me then. 
:)



##########
build.xml:
##########
@@ -307,6 +307,72 @@
         <equals arg1="${ant.java.version}" arg2="17"/>
     </condition>
 
+    <resources id="_jvm21_arg_items">
+        <string>-Djdk.attach.allowAttachSelf=true</string>
+
+        <string>-XX:+UseZGC</string>

Review Comment:
   > this is something David and others are seeing on a fork that includes this 
upstream work, not the ASF branch itself.
   
   That is a good clarification that was not mentioned earlier. Please ignore 
me then. :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to