netudima commented on code in PR #2497: URL: https://github.com/apache/cassandra/pull/2497#discussion_r2098915780
########## src/java/org/apache/cassandra/tools/nodetool/EnableAutoCompaction.java: ########## @@ -17,25 +17,37 @@ */ package org.apache.cassandra.tools.nodetool; -import io.airlift.airline.Arguments; -import io.airlift.airline.Command; - import java.io.IOException; import java.util.ArrayList; import java.util.List; import org.apache.cassandra.tools.NodeProbe; -import org.apache.cassandra.tools.NodeTool.NodeToolCmd; + +import org.apache.cassandra.tools.nodetool.layout.CassandraUsage; +import picocli.CommandLine.Command; +import picocli.CommandLine.Parameters; + +import static org.apache.cassandra.tools.nodetool.CommandUtils.parseOptionalKeyspace; +import static org.apache.cassandra.tools.nodetool.CommandUtils.parseOptionalTables; +import static org.apache.cassandra.tools.nodetool.CommandUtils.concatArgs; @Command(name = "enableautocompaction", description = "Enable autocompaction for the given keyspace and table") -public class EnableAutoCompaction extends NodeToolCmd +public class EnableAutoCompaction extends AbstractCommand { - @Arguments(usage = "[<keyspace> <tables>...]", description = "The keyspace followed by one or many tables") + @CassandraUsage(usage = "[<keyspace> <tables>...]", description = "The keyspace followed by one or many tables") private List<String> args = new ArrayList<>(); + @Parameters(index = "0", description = "The keyspace to enable auto-compaction on", arity = "0..1") + private String keyspace; + + @Parameters(index = "1..*", description = "The tables to enable auto-compaction on", arity = "0..1") Review Comment: why do we have 0..1 arity here if multiple tables are supported here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org