netudima commented on code in PR #2497:
URL: https://github.com/apache/cassandra/pull/2497#discussion_r2098965430
##########
src/java/org/apache/cassandra/tools/nodetool/SetTimeout.java:
##########
@@ -17,28 +17,36 @@
*/
package org.apache.cassandra.tools.nodetool;
-import io.airlift.airline.Arguments;
-import io.airlift.airline.Command;
import java.util.ArrayList;
import java.util.List;
import org.apache.cassandra.tools.NodeProbe;
-import org.apache.cassandra.tools.NodeTool.NodeToolCmd;
+import org.apache.cassandra.tools.nodetool.layout.CassandraUsage;
+import picocli.CommandLine.Command;
+import picocli.CommandLine.Parameters;
import static com.google.common.base.Preconditions.checkArgument;
+import static org.apache.cassandra.tools.nodetool.CommandUtils.concatArgs;
@Command(name = "settimeout", description = "Set the specified timeout in ms,
or 0 to disable timeout")
-public class SetTimeout extends NodeToolCmd
+public class SetTimeout extends AbstractCommand
{
- @Arguments(usage = "<timeout_type> <timeout_in_ms>", description =
"Timeout type followed by value in ms " +
- "(0 disables socket streaming timeout). Type should be one of (" +
GetTimeout.TIMEOUT_TYPES + ")",
- required = true)
+ @CassandraUsage(usage = "<timeout_type> <timeout_in_ms>", description =
"Timeout type followed by value in ms " +
+
"(0 disables socket streaming timeout). Type should be one of (" +
GetTimeout.TIMEOUT_TYPES + ")")
private List<String> args = new ArrayList<>();
+ @Parameters(paramLabel = "timeout_type", description = "Timeout type",
index = "0", arity = "0..1")
Review Comment:
Should it be arity = 1 ? (mandatory)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
