SiyaoIsHiding commented on code in PR #2037:
URL:
https://github.com/apache/cassandra-java-driver/pull/2037#discussion_r2103611554
##########
core/src/main/java/com/datastax/oss/driver/internal/core/cql/CqlRequestHandler.java:
##########
@@ -139,7 +144,9 @@ protected CqlRequestHandler(
String sessionLogPrefix) {
this.startTimeNanos = System.nanoTime();
- this.logPrefix = sessionLogPrefix + "|" + this.hashCode();
+ this.requestIdGenerator = context.getRequestIdGenerator();
+ this.logPrefix =
+ this.requestIdGenerator.getSessionRequestId(statement,
sessionLogPrefix, this.hashCode());
Review Comment:
This current implementation of request ID relies on the old log prefix
implementation to propagate to other classes, like `RequestLogger` and
`InFlightHandler`. If we separate request ID with log prefix, how do we
propagate request ID?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
