SiyaoIsHiding commented on code in PR #2037:
URL:
https://github.com/apache/cassandra-java-driver/pull/2037#discussion_r2316618930
##########
core/src/main/java/com/datastax/oss/driver/api/core/tracker/RequestTracker.java:
##########
@@ -142,22 +146,23 @@ default void onNodeSuccess(
@NonNull Node node) {}
/**
- * Invoked each time a request succeeds at the node level. Similar to {@link
#onSuccess(Request,
- * long, DriverExecutionProfile, Node, String)} but at per node level.
+ * Invoked each time a node request succeeds. A node request is a CQL
request sent to a particular
+ * node. There can be one or more node requests for a single session
request, due to retries or
+ * speculative executions.
*
* @param latencyNanos the overall execution time (from the {@link
Session#execute(Request,
* GenericType) session.execute} call until the result is made available
to the client).
* @param executionProfile the execution profile of this request.
* @param node the node that returned the successful response.
- * @param requestLogPrefix the dedicated log prefix for this request
+ * @param nodeRequestLogPrefix the dedicated log prefix for this request
*/
default void onNodeSuccess(
@NonNull Request request,
long latencyNanos,
@NonNull DriverExecutionProfile executionProfile,
@NonNull Node node,
- @NonNull String requestLogPrefix) {
- // If client doesn't override onNodeSuccess with requestLogPrefix delegate
call to the old
+ @NonNull String nodeRequestLogPrefix) {
+ // If client doesn't override onNodeSuccess with nodeRequestLogPrefix
delegate call to the old
Review Comment:
Current Implementation, with W3Ccontext: onNodeSuccess(theRequest, 100,
theProfile, theNode, "00-1273534231-3435342-01");
Current Implementation unspecified: onNodeSuccess(theRequest, 100,
theProfile, theNode, "s0|1937567123|0");
Proposed Implementation with W3CContext: onNodeSuccess(theRequest, 100,
theProfile, theNode, "s0|00-1273534231-3435342-01|0");
Proposed Implementation unspecified: onNodeSuccess(theRequest, 100,
theProfile, theNode, "s0|1937567123|0");
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
