pranavshenoy commented on code in PR #4153:
URL: https://github.com/apache/cassandra/pull/4153#discussion_r2103830008
##########
src/java/org/apache/cassandra/cql3/transactions/ConditionStatement.java:
##########
@@ -100,12 +100,18 @@ public ConditionStatement prepare(String keyspace,
VariableSpecifications bindVa
if (lhs instanceof RowDataReference.Raw)
{
+ if (((RowDataReference.Raw) lhs).column() == null) {
+ throw new IllegalStateException(String.format("Row
reference (%s) can only be used with IS NULL/IS NOT NULL conditions",
lhs.getText()));
Review Comment:
@dcapwell Wouldn't IS NULL/ IS NOT NULL gets returned earlier itself?
In
[this](https://github.com/apache/cassandra/blob/52e982389c9a2bc1c80f4473480a072bad6e78c4/src/java/org/apache/cassandra/cql3/transactions/ConditionStatement.java#L90C14-L91C1)
snippet, we check if rhs is NULL.
Wouldn't IS NULL/ IS NOT NULL go into this IF block?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
