pranavshenoy commented on PR #4153: URL: https://github.com/apache/cassandra/pull/4153#issuecomment-2921266905
> Please add tests for this check. > > There are 2 places that make sense > > 1. does the checks actually work: `org.apache.cassandra.distributed.test.accord.AccordCQLTestBase`. there should be tests already for the happy path > 2. we reject when we are expected to: `org.apache.cassandra.cql3.statements.TransactionStatementTest` @dcapwell I have added unit tests in TransactionStatementTest. Curious, wouldn't #1 & #2 the same? Doesn't the extra check working means we reject the TransactionStatement? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
