netudima commented on code in PR #2497: URL: https://github.com/apache/cassandra/pull/2497#discussion_r2106308712
########## src/java/org/apache/cassandra/tools/nodetool/CommandUtils.java: ########## @@ -0,0 +1,239 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.tools.nodetool; + +import java.io.PrintStream; +import java.lang.reflect.Field; +import java.net.UnknownHostException; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collection; +import java.util.Collections; +import java.util.Comparator; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.SortedMap; +import java.util.stream.Collectors; +import java.util.stream.Stream; + +import com.google.common.collect.Maps; + +import org.apache.cassandra.locator.EndpointSnitchInfoMBean; +import org.apache.cassandra.tools.NodeProbe; +import org.apache.cassandra.tools.nodetool.formatter.TableBuilder; +import org.apache.cassandra.tools.nodetool.layout.CassandraUsage; +import org.apache.cassandra.utils.Pair; + +import static com.google.common.collect.Iterables.toArray; +import static java.util.stream.Stream.concat; +import static java.util.stream.Stream.ofNullable; +import static org.apache.commons.lang3.ArrayUtils.EMPTY_STRING_ARRAY; + +/** + * Utility methods for nodetool commands. + */ +public final class CommandUtils +{ + private CommandUtils() {} + + /** + * Returns a string with the given number of leading spaces. + * + * @param num the number of leading spaces + * @return the string with the given number of leading spaces + */ + public static String leadingSpaces(int num) + { + char[] buff = new char[num]; + Arrays.fill(buff, ' '); + return new String(buff); + } + + public static int maxLength(Collection<?> any) + { + int result = 0; + for (Object value : any) + result = Math.max(result, String.valueOf(value).length()); + return result; + } + + public static Pair<String, String> findCassandraBackwardCompatibleArgument(Object userObject) + { + Class<?> clazz = userObject.getClass(); + do + { + for (Field field : clazz.getDeclaredFields()) + { + if (field.isAnnotationPresent(CassandraUsage.class)) + { + CassandraUsage ann = field.getAnnotation(CassandraUsage.class); + return Pair.create(ann.usage(), ann.description()); + } + } + } + while ((clazz = clazz.getSuperclass()) != null); + return null; + } + + public static String[] sortShortestFirst(String[] names) + { + Arrays.sort(names, Comparator.comparing(String::length)); + return names; + } + + public static List<String> concatArgs(String first, String second) + { + return concat(ofNullable(first), ofNullable(second)).collect(Collectors.toList()); + } + + public static List<String> concatArgs(String first, String second, String third) + { + return concat(ofNullable(first), concatArgs(second, third).stream()).collect(Collectors.toList()); + } + + public static List<String> concatArgs(String first, String second, String third, String fourth) + { + return concat(ofNullable(first), concatArgs(second, third, fourth).stream()).collect(Collectors.toList()); + } + + public static List<String> concatArgs(String first, String[] second) + { + return concat(ofNullable(first), (second == null ? Stream.empty() : Arrays.stream(second))).collect(Collectors.toList()); + } + + public static List<String> concatArgs(String first, List<String> second) + { + return concat(ofNullable(first), (second == null ? Stream.empty() : second.stream())).collect(Collectors.toList()); + } + + public static List<String> concatArgs(String first, String second, String[] third) + { + return concat(ofNullable(first), concatArgs(second, third).stream()).collect(Collectors.toList()); + } + + public static List<String> concatArgs(String first, String second, List<String> third) + { + return concat(ofNullable(first), concatArgs(second, third).stream()).collect(Collectors.toList()); + } + + public static List<String> concatArgs(String first, String second, String third, String[] fourth) + { + return concat(ofNullable(first), concatArgs(second, third, fourth).stream()).collect(Collectors.toList()); + } + + public static void printSet(PrintStream out, String colName, Set<String> values) + { + if (values == null || values.isEmpty()) + return; + + TableBuilder table = new TableBuilder(); + + table.add(colName + ": "); + + for (String value : values) + table.add(value); + + table.printTo(out); + } + + public static List<String> parseOptionalKeyspaceAccordManaged(List<String> cmdArgs, NodeProbe nodeProbe) + { + return parseOptionalKeyspace(cmdArgs, nodeProbe, KeyspaceSet.ACCORD_MANAGED); + } + + public static List<String> parseOptionalKeyspace(List<String> cmdArgs, NodeProbe nodeProbe) + { + return parseOptionalKeyspace(cmdArgs, nodeProbe, KeyspaceSet.ALL); + } + + public static List<String> parseOptionalKeyspaceNonLocal(List<String> cmdArgs, NodeProbe nodeProbe) + { + return parseOptionalKeyspace(cmdArgs, nodeProbe, KeyspaceSet.NON_LOCAL_STRATEGY); + } + + private static List<String> parseOptionalKeyspace(List<String> cmdArgs, NodeProbe nodeProbe, KeyspaceSet defaultKeyspaceSet) + { + List<String> keyspaces = new ArrayList<>(); + + + if (cmdArgs == null || cmdArgs.isEmpty()) + { + if (defaultKeyspaceSet == KeyspaceSet.NON_LOCAL_STRATEGY) + keyspaces.addAll(keyspaces = nodeProbe.getNonLocalStrategyKeyspaces()); + else if (defaultKeyspaceSet == KeyspaceSet.NON_SYSTEM) + keyspaces.addAll(keyspaces = nodeProbe.getNonSystemKeyspaces()); + else if (defaultKeyspaceSet == KeyspaceSet.ACCORD_MANAGED) + keyspaces.addAll(nodeProbe.getAccordManagedKeyspaces()); + + else + keyspaces.addAll(nodeProbe.getKeyspaces()); + } + else + { + keyspaces.add(cmdArgs.get(0)); + } + + for (String keyspace : keyspaces) + { + if (!nodeProbe.getKeyspaces().contains(keyspace)) + throw new IllegalArgumentException("Keyspace [" + keyspace + "] does not exist."); + } + + return Collections.unmodifiableList(keyspaces); + } + + public static String[] parseOptionalTables(List<String> cmdArgs) Review Comment: probably a comment/javadoc is needed about an input/output format here, not obvious.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
