netudima commented on code in PR #2497:
URL: https://github.com/apache/cassandra/pull/2497#discussion_r2106313231
##########
src/java/org/apache/cassandra/tools/nodetool/SetCompactionThreshold.java:
##########
@@ -17,26 +17,41 @@
*/
package org.apache.cassandra.tools.nodetool;
-import static com.google.common.base.Preconditions.checkArgument;
-import static java.lang.Integer.parseInt;
-import io.airlift.airline.Arguments;
-import io.airlift.airline.Command;
-
import java.util.ArrayList;
import java.util.List;
import org.apache.cassandra.tools.NodeProbe;
-import org.apache.cassandra.tools.NodeTool.NodeToolCmd;
+import org.apache.cassandra.tools.nodetool.layout.CassandraUsage;
+import picocli.CommandLine.Command;
+import picocli.CommandLine.Parameters;
+
+import static com.google.common.base.Preconditions.checkArgument;
+import static java.lang.Integer.parseInt;
+import static org.apache.cassandra.tools.nodetool.CommandUtils.concatArgs;
@Command(name = "setcompactionthreshold", description = "Set min and max
compaction thresholds for a given table")
-public class SetCompactionThreshold extends NodeToolCmd
+public class SetCompactionThreshold extends AbstractCommand
{
- @Arguments(title = "<keyspace> <table> <minthreshold> <maxthreshold>",
usage = "<keyspace> <table> <minthreshold> <maxthreshold>", description = "The
keyspace, the table, min and max threshold", required = true)
+ @CassandraUsage(usage = "<keyspace> <table> <minthreshold>
<maxthreshold>", description = "The keyspace, the table, min and max threshold")
private List<String> args = new ArrayList<>();
+ @Parameters(paramLabel = "keyspace", description = "The keyspace name",
arity = "0..1", index = "0")
Review Comment:
should the parameters be mandatory?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
