netudima commented on code in PR #2497:
URL: https://github.com/apache/cassandra/pull/2497#discussion_r2106313666


##########
src/java/org/apache/cassandra/tools/nodetool/Sjk.java:
##########
@@ -234,15 +221,11 @@ public boolean run(final NodeProbe probe, final Output 
output)
                 {
                     printUsage(parser, out, parser.getParsedCommand());
                 }
-                return true;
             }
             catch (Throwable e)
             {
                 e.printStackTrace(err);
             }
-

Review Comment:
   do we ignore failure propagation and potentially change a result code here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to