aweisberg commented on code in PR #4111:
URL: https://github.com/apache/cassandra/pull/4111#discussion_r2122019667
##########
src/java/org/apache/cassandra/service/accord/txn/TxnQuery.java:
##########
@@ -217,6 +217,9 @@ public Result compute(TxnId txnId, Timestamp executeAt,
Seekables<?, ?> keys, @N
ClientRequestsMetricsHolder.accordWriteMetrics.accordMigrationRejects.mark();
else
ClientRequestsMetricsHolder.accordReadMetrics.accordMigrationRejects.mark();
+ // Prevent writes from being applied
+ if (update != null)
+ ((TxnUpdate)update).failCondition();
Review Comment:
It should be deterministic. Live migration is predicated on this being true.
That said the checks `TxnQuery` still needs to be updated to be done using the
information from the actual epoch rather than the arbitrary current epoch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
