joao-r-reis commented on code in PR #1755:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1755#discussion_r2143288949
##########
conn_test.go:
##########
@@ -349,15 +350,21 @@ func TestCancel(t *testing.T) {
type testQueryObserver struct {
metrics map[string]*hostMetrics
verbose bool
- logger StdLogger
+ logger StructuredLogger
}
func (o *testQueryObserver) ObserveQuery(ctx context.Context, q ObservedQuery)
{
host := q.Host.ConnectAddress().String()
o.metrics[host] = q.Metrics
if o.verbose {
Review Comment:
Hmm currently `o.verbose` is always `false` so my guess is that this is some
inactive code that we can enable when debugging a test failure or something.
I'm going to remove the flag and I'm going to set the log level in the test
logger here to `None` so we can just change this log level whenever we want to
debug these tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
