joao-r-reis commented on code in PR #1755: URL: https://github.com/apache/cassandra-gocql-driver/pull/1755#discussion_r2143330388
########## session.go: ########## @@ -234,6 +234,7 @@ func (s *Session) init() error { // TODO(zariel): we really only need this in 1 place s.cfg.ProtoVersion = proto s.connCfg.ProtoVersion = proto + s.logger.Info("Discovered protocol version.", newLogFieldInt("protocol_version", proto)) Review Comment: I agree with you in principle but in practice most users aren't really aware of what protocol versions are or at least the differences between them and the potential impact there is when there is a change on the server version. Sometimes users even run clusters in a "hybrid state" during upgrades where the version that the driver uses will depend on which C* node is the control host. I personally think this is important enough to deserve INFO level but I can also see your point so if after reading this you still think this should be DEBUG I'll change it, lmk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org