netudima commented on code in PR #4166: URL: https://github.com/apache/cassandra/pull/4166#discussion_r2153138546
########## conf/cassandra-env.sh: ########## @@ -199,6 +199,44 @@ if [ "x$CASSANDRA_HEAPDUMP_DIR" = "x" ]; then fi JVM_OPTS="$JVM_OPTS -XX:HeapDumpPath=$CASSANDRA_HEAPDUMP_DIR/cassandra-`date +%s`-pid$$.hprof" +# Cassandra heap dump files management options: +# if not set externally, this script assigns defauls: +# - enable heap dump files clean up +# - keeping 2 newest files +# - keeping 1 oldest file to help identify first OOM incident +if [ "$CASSANDRA_HEAPDUMP_CLEAN" = "" ]; then Review Comment: what is about not introducing a separate CASSANDRA_HEAPDUMP_CLEAN option here and just use a negative value for CASSANDRA_HEAPDUMP_KEEP_NEWEST_N_FILES to disable this feature? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
